Well written codebases get reviewed in one iteration (one set of comments, one round of fixes, good to go).Getting comments on your PR is good, it means you are alive and learning. No comments on a PR means the review was not thorough enough.Mark pull requests that should not be merged as "WIP" in the PR title ("WIP: new settings page").You can use multiple reviewers for different types of code. Every piece of code (backend, database changes, HTML, CSS) must be reviewed.You need to tag the reviewers in the description of your pull request This is especially important on larger projects because it helps people know what PRs need their attention.Bonus points if you find issues in the code of senior people! Finding and pointing out issues in PRs is a good thing.Getting a third opinion is a good option. ![]() if you don't want to do it, say why and come to an agreement with your reviewer about this issue.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |